Summary: | REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Levin <levin> | ||||
Component: | Tools / Tests | Assignee: | David Levin <levin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, dpranke | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 58202 | ||||||
Attachments: |
|
Description
David Levin
2011-04-10 08:41:13 PDT
Created attachment 88950 [details]
Patch
See dependent bug for the follow up to remove the fixme (and do a better fix). Comment on attachment 88950 [details]
Patch
ok.
Committed as http://trac.webkit.org/changeset/83398 From looking at the python code implementing subprocess, it looks like either os.waitpid() could be returning something weird, or it could be raising os.error. So, something's definitely wrong, but having NRWT fall over at that point isn't all that useful, so your change is good. I will see if I can follow-up and reproduce it in bug 58202. |