| Summary: | new-run-webkit-tests: fix crash when running under windows cmd.exe | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, aroben, eric, mihaip, ojan, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2011-04-09 20:03:48 PDT
Created attachment 88943 [details]
Patch
Comment on attachment 88943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217 > + self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE) Would it be better to use devnull? (In reply to comment #2) > (From update of attachment 88943 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217 > > + self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE) > > Would it be better to use devnull? In limited testing, that does appear to work as well; An advantage to subprocess.PIPE, is that it gets cleaned up automatically when I close the process, which keeps the code slightly cleaner. Committed r83477: <http://trac.webkit.org/changeset/83477> |