Bug 58179

Summary: WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are updated correctly
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit2Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, jberlin, webkit-ews
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch none

Jessie Berlin
Reported 2011-04-08 17:08:32 PDT
<rdar://problem/9254302>
Attachments
Patch (8.98 KB, patch)
2011-04-08 17:21 PDT, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jessie Berlin
Comment 1 2011-04-08 17:21:08 PDT
Created attachment 88905 [details] Patch
Early Warning System Bot
Comment 2 2011-04-08 17:38:02 PDT
Attachment 88905 [details] did not build on qt: Build output: http://queues.webkit.org/results/8376192
Jessie Berlin
Comment 3 2011-04-08 18:17:41 PDT
(In reply to comment #2) > Attachment 88905 [details] did not build on qt: > Build output: http://queues.webkit.org/results/8376192 I guess nested #if do not parse correctly in the messages.in file. I will fix that and commit. Thanks for the review Anders!
Build Bot
Comment 4 2011-04-08 18:34:03 PDT
Attachment 88905 [details] did not build on win: Build output: http://queues.webkit.org/results/8379196
Jessie Berlin
Comment 5 2011-04-08 18:40:13 PDT
Comment on attachment 88905 [details] Patch Committed in http://trac.webkit.org/changeset/83369. The build fix in that patch for Qt should also avoid breaking the Win build.
Note You need to log in before you can comment on or make changes to this bug.