Bug 58169

Summary: Make the drag operations be different functions
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Anders Carlsson
Reported 2011-04-08 15:54:53 PDT
Make the drag operations be different functions
Attachments
Patch (8.32 KB, patch)
2011-04-08 15:56 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-04-08 15:56:07 PDT
Created attachment 88889 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-04-08 15:57:44 PDT
Comment on attachment 88889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88889&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:699 > + void performDragControllerAction(DragControllerAction, WebCore::DragData*, const String& = String()); I guess this doesn't need a default value anymore. It would be nice to name the last parameter in this function and the new ones you added. The signature is a bit mysterious without it.
Anders Carlsson
Comment 3 2011-04-08 16:00:36 PDT
Committed r83354: <http://trac.webkit.org/changeset/83354>
Note You need to log in before you can comment on or make changes to this bug.