Bug 58169

Summary:

Make the drag operations be different functions

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	aroben: review+

Description Anders Carlsson 2011-04-08 15:54:53 PDT

Make the drag operations be different functions

Comment 1 Anders Carlsson 2011-04-08 15:56:07 PDT

Created attachment 88889 [details]
Patch

Comment 2 Adam Roben (:aroben) 2011-04-08 15:57:44 PDT

Comment on attachment 88889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88889&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:699
> +    void performDragControllerAction(DragControllerAction, WebCore::DragData*, const String& = String());

I guess this doesn't need a default value anymore.

It would be nice to name the last parameter in this function and the new ones you added. The signature is a bit mysterious without it.

Comment 3 Anders Carlsson 2011-04-08 16:00:36 PDT

Committed r83354: <http://trac.webkit.org/changeset/83354>