| Summary: | Parse 'DispatchOnConnectionQueue' in messages.in files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2011-04-08 15:28:55 PDT
Created attachment 88884 [details]
Patch
Comment on attachment 88884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88884&action=review > Source/WebKit2/Scripts/webkit2/messages.py:84 > - match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(delayed))?)?', line) > + match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line) I think you could simplify this: (?:\s+(.*))? to this: (.*) > Source/WebKit2/Scripts/webkit2/messages_unittest.py:69 > - GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins) > - GetPluginProcessConnection(WTF::String pluginPath) -> (CoreIPC::Connection::Handle connectionHandle) delayed > + GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins) DispatchOnConnectionQueue > + GetPluginProcessConnection(WTF::String pluginPath) -> (CoreIPC::Connection::Handle connectionHandle) Delayed Would be good to add a test that has more than one attribute. Committed r83350: <http://trac.webkit.org/changeset/83350> |