Bug 58164

Summary:

prepare-ChangeLog support email input but -h did not show the option

Product:

WebKit

Reporter:

George Guo <george.guo>

Component:

Tools / Tests

Assignee:

George Guo <george.guo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, george.guo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
A patch for review	eric: review+, eric: commit-queue-
A new patch that follows the style and without tab	none

George Guo

Reported 2011-04-08 14:07:48 PDT

It's nice to be able to enter email address at command line by prepare-ChangeLog --email= option. However when you do the commandline prepare-ChangeLog --help, it did not mention the email option. I think it would be nice to let user know the email option when user use --help. This will improve the usability of prepare-ChangeLog

Attachments
A patch for review (1.25 KB, patch) 2011-04-08 14:15 PDT, George Guo	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
A new patch that follows the style and without tab (1.25 KB, patch) 2011-04-11 12:40 PDT, George Guo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

George Guo

Comment 1 2011-04-08 14:15:38 PDT

Created attachment 88874 [details] A patch for review

WebKit Review Bot

Comment 2 2011-04-08 14:18:28 PDT

Attachment 88874 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 3 2011-04-09 01:52:48 PDT

Comment on attachment 88874 [details] A patch for review LGTM except the tab.

George Guo

Comment 4 2011-04-09 07:48:33 PDT

I'll try to find tab in the file, BTW, is there any good tool find it? Thanks

Eric Seidel (no email)

Comment 5 2011-04-09 08:13:18 PDT

(In reply to comment #2) > Attachment 88874 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 > > Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] The style-bot knows all. :)

George Guo

Comment 6 2011-04-11 12:40:26 PDT

Created attachment 89056 [details] A new patch that follows the style and without tab

Eric Seidel (no email)

Comment 7 2011-04-11 13:07:14 PDT

Comment on attachment 89056 [details] A new patch that follows the style and without tab Thank you very much.

Eric Seidel (no email)

Comment 8 2011-04-11 13:07:49 PDT

Comment on attachment 88874 [details] A patch for review FYI: webkit-patch upload will automatically obsolete previous patches when uploading new ones. (If you chose to use webkit-patch.)

WebKit Commit Bot

Comment 9 2011-04-11 18:13:33 PDT

Comment on attachment 89056 [details] A new patch that follows the style and without tab Clearing flags on attachment: 89056 Committed r83546: <http://trac.webkit.org/changeset/83546>

WebKit Commit Bot

Comment 10 2011-04-11 18:13:38 PDT

All reviewed patches have been landed. Closing bug.

George Guo

Comment 11 2011-04-11 18:27:00 PDT

Thanks Eric, it's good learning for me for the process

Note You need to log in before you can comment on or make changes to this bug.