Bug 58164

Summary:

prepare-ChangeLog support email input but -h did not show the option

Product:

WebKit

Reporter:

George Guo <george.guo>

Component:

Tools / Tests

Assignee:

George Guo <george.guo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, george.guo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
A patch for review	eric: review+, eric: commit-queue-
A new patch that follows the style and without tab	none

Description George Guo 2011-04-08 14:07:48 PDT

It's nice to be able to enter email address at command line by prepare-ChangeLog --email= option.

However when you do the commandline prepare-ChangeLog --help, it did not mention the email option.

I think it would be nice to let user know the email option when user use --help. This will improve the usability of prepare-ChangeLog

Comment 1 George Guo 2011-04-08 14:15:38 PDT

Created attachment 88874 [details]
A patch for review

Comment 2 WebKit Review Bot 2011-04-08 14:18:28 PDT

Attachment 88874 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1

Tools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Eric Seidel (no email) 2011-04-09 01:52:48 PDT

Comment on attachment 88874 [details]
A patch for review

LGTM except the tab.

Comment 4 George Guo 2011-04-09 07:48:33 PDT

I'll try to find tab in the file, BTW, is there any good tool find it? Thanks

Comment 5 Eric Seidel (no email) 2011-04-09 08:13:18 PDT

(In reply to comment #2)
> Attachment 88874 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1
> 
> Tools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]

The style-bot knows all. :)

Comment 6 George Guo 2011-04-11 12:40:26 PDT

Created attachment 89056 [details]
A new patch that follows the style and without tab

Comment 7 Eric Seidel (no email) 2011-04-11 13:07:14 PDT

Comment on attachment 89056 [details]
A new patch that follows the style and without tab

Thank you very much.

Comment 8 Eric Seidel (no email) 2011-04-11 13:07:49 PDT

Comment on attachment 88874 [details]
A patch for review

FYI: webkit-patch upload will automatically obsolete previous patches when uploading new ones.  (If you chose to use webkit-patch.)

Comment 9 WebKit Commit Bot 2011-04-11 18:13:33 PDT

Comment on attachment 89056 [details]
A new patch that follows the style and without tab

Clearing flags on attachment: 89056

Committed r83546: <http://trac.webkit.org/changeset/83546>

Comment 10 WebKit Commit Bot 2011-04-11 18:13:38 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 George Guo 2011-04-11 18:27:00 PDT

Thanks Eric, it's good learning for me for the process