Bug 58154

Summary: Add support for comparison operators to the DFG JIT.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch, no performance impact. oliver: review+

Gavin Barraclough
Reported 2011-04-08 12:51:04 PDT
Add support for <, <=, ==, ===, and also !. Add support for all corresponding bytecode ops, including the not- and -null forms. Initially add functionally correct support, we'll revisit the performance.
Attachments
The patch, no performance impact. (25.79 KB, patch)
2011-04-08 12:56 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-04-08 12:56:39 PDT
Created attachment 88862 [details] The patch, no performance impact.
WebKit Review Bot
Comment 2 2011-04-08 12:58:42 PDT
Attachment 88862 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/JavaScriptCore/jit/JITOpcodes.cpp:60: string_failureCases3 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2011-04-08 14:16:07 PDT
Fixed in r83337.
Note You need to log in before you can comment on or make changes to this bug.