Bug 58151

Summary: Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc
Product: WebKit Reporter: Alice Liu <alice.barraclough>
Component: WebKit2Assignee: Alice Liu <alice.barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
Attachments:
Description Flags
patch
none
patch with correct changelog aroben: review+

Alice Liu
Reported 2011-04-08 12:04:55 PDT
On windows, after closing a WebKit2 WebView we can crash in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc. This is happening because when WebKit2 WebViews close, we aren't removing that webview from the list of WindowMessageBroadcaster listeners. <rdar://problem/8779099>
Attachments
patch (1.36 KB, patch)
2011-04-08 12:07 PDT, Alice Liu 		no flags
DetailsFormatted DiffDiff
patch with correct changelog (1.82 KB, patch)
2011-04-08 12:11 PDT, Alice Liu 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alice Liu
Comment 1 2011-04-08 12:07:25 PDT
Created attachment 88855 [details] patch
WebKit Review Bot
Comment 2 2011-04-08 12:08:14 PDT
Attachment 88855 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alice Liu
Comment 3 2011-04-08 12:11:45 PDT
Created attachment 88856 [details] patch with correct changelog
Adam Roben (:aroben)
Comment 4 2011-04-08 12:55:12 PDT
Comment on attachment 88856 [details] patch with correct changelog Is it possible to make a test for this using TestWebKitAPI? If you know the sequence of events that lead to the crash it should be pretty easy to simulate them in TestWebKitAPI.
Alice Liu
Comment 5 2011-04-08 16:50:25 PDT
(In reply to comment #4) I'm unsure if it's possible. The crash wasn't always reproducible even with the application-specific webview that it was happening with. And my guess is that it's not guaranteed that we'll be able to replicate the situational prerequisites for the crash with TestWebKitAPI, especially if i don't know what they are at the moment.
Alice Liu
Comment 6 2011-04-08 16:51:41 PDT
http://trac.webkit.org/changeset/83357
Note You need to log in before you can comment on or make changes to this bug.