Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc

• Component: WebKit2
• Status: RESOLVED FIXED

[Alice Liu]

On windows, after closing a WebKit2 WebView we can crash in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc.  This is happening because when WebKit2 WebViews close, we aren't removing that webview from the list of WindowMessageBroadcaster listeners.  

<rdar://problem/8779099>

[Alice Liu]

Created attachment 88855 [details]
patch

[WebKit Review Bot]

Attachment 88855 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alice Liu]

Created attachment 88856 [details]
patch with correct changelog

[Adam Roben (:aroben)]

Comment on attachment 88856 [details]
patch with correct changelog

Is it possible to make a test for this using TestWebKitAPI? If you know the sequence of events that lead to the crash it should be pretty easy to simulate them in TestWebKitAPI.

[Alice Liu]

(In reply to comment #4)
I'm unsure if it's possible.  The crash wasn't always reproducible even with the application-specific webview that it was happening with. And my guess is that it's not guaranteed that we'll be able to replicate the situational prerequisites for the crash with TestWebKitAPI, especially if i don't know what they are at the moment.

[Alice Liu]

http://trac.webkit.org/changeset/83357