Summary: | PerformanceTiming returns inconsistent values when timing is null. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vsevolod Vlasov <vsevik> | ||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | caseq, commit-queue, eric, jamesr, pfeldman, simonjam, tonyg | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Vsevolod Vlasov
2011-04-08 08:54:22 PDT
Created attachment 88876 [details]
Patch
Comment on attachment 88876 [details]
Patch
How do we test this?
This is tested in fast/dom/webtiming*.html layout tests. After landing of http://codereview.chromium.org/6823006/ these tests would fail, unless this patch is also landed. (In reply to comment #3) > This is tested in fast/dom/webtiming*.html layout tests. > After landing of http://codereview.chromium.org/6823006/ these tests would fail, unless this patch is also landed. Ideally the ChagneLog would contain this information. :) Comment on attachment 88876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review > Source/WebCore/page/PerformanceTiming.cpp:264 > + return requestStart(); You probably should do the same for the secureConnection timers above and for the responseEnd below. Comment on attachment 88876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review >> Source/WebCore/page/PerformanceTiming.cpp:264 >> + return requestStart(); > > You probably should do the same for the secureConnection timers above and for the responseEnd below. secureConnection: "If this attribute is available but HTTPS is not used, this attribute must return zero.", so zero is correct. respondEnd is filled from documentLoadTiming, not resourceLoadTiming, so its value is correct as well. Thanks for taking care of this. The commit-queue encountered the following flaky tests while processing attachment 88876 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 88876 [details] Patch Clearing flags on attachment: 88876 Committed r83491: <http://trac.webkit.org/changeset/83491> All reviewed patches have been landed. Closing bug. |