Bug 58124

Summary: Web Inspector: HAR compliance fixes
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch yurys: review+

Description Andrey Kosyakov 2011-04-08 02:11:02 PDT 
Small batch of fixes for HAR standard compliance:
- Always provide some values for queryString and cookies, even though arrays may be empty
- Always provide an empty cache object
- Added entire HARLog to test
- Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)
Comment 1 Andrey Kosyakov 2011-04-08 02:22:54 PDT 
Created attachment 88784 [details]
patch
Comment 2 Yury Semikhatsky 2011-04-08 02:27:44 PDT 
Comment on attachment 88784 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88784&action=review

> Source/WebCore/inspector/front-end/HAREntry.js:48
> +            cache: { }, // Not supproted yet.

Please file a bug on this and add a FIXME here.
Comment 3 Andrey Kosyakov 2011-04-08 02:56:01 PDT 
Added FIXME, filed bug 58127 for other missing fields.

Manually committed r83275: http://trac.webkit.org/changeset/83275
Comment 4 WebKit Review Bot 2011-04-08 03:21:06 PDT 
http://trac.webkit.org/changeset/83275 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-parameters.html