Bug 58119

Summary:

[GTK] layoutTestController.shadowRoot should return undefined if its argument is not an element

Product:

WebKit

Reporter:

Dominic Cooney <dominicc>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Dominic Cooney 2011-04-08 00:09:01 PDT

For consistency with other ports' DRT, layoutTestController.shadowRoot should return undefined, not null, if its argument is not an element.

Comment 1 Dominic Cooney 2011-04-08 00:11:10 PDT

Created attachment 88776 [details]
Patch

Comment 2 WebKit Commit Bot 2011-04-08 02:24:03 PDT

The commit-queue encountered the following flaky tests while processing attachment 88776 [details]:

http/tests/inspector/console-xhr-logging.html bug 58125 (authors: caseq@chromium.org, darin@apple.com, loislo@chromium.org, and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.

Comment 3 WebKit Commit Bot 2011-04-08 02:26:18 PDT

Comment on attachment 88776 [details]
Patch

Clearing flags on attachment: 88776

Committed r83272: <http://trac.webkit.org/changeset/83272>

Comment 4 WebKit Commit Bot 2011-04-08 02:26:24 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 WebKit Review Bot 2011-04-08 03:21:00 PDT

http://trac.webkit.org/changeset/83272 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-parameters.html