Bug 58119

Summary: [GTK] layoutTestController.shadowRoot should return undefined if its argument is not an element
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Dominic Cooney
Reported 2011-04-08 00:09:01 PDT
For consistency with other ports' DRT, layoutTestController.shadowRoot should return undefined, not null, if its argument is not an element.
Attachments
Patch (1.44 KB, patch)
2011-04-08 00:11 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-04-08 00:11:10 PDT
Created attachment 88776 [details] Patch
WebKit Commit Bot
Comment 2 2011-04-08 02:24:03 PDT
The commit-queue encountered the following flaky tests while processing attachment 88776 [details]: http/tests/inspector/console-xhr-logging.html bug 58125 (authors: caseq@chromium.org, darin@apple.com, loislo@chromium.org, and pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2011-04-08 02:26:18 PDT
Comment on attachment 88776 [details] Patch Clearing flags on attachment: 88776 Committed r83272: <http://trac.webkit.org/changeset/83272>
WebKit Commit Bot
Comment 4 2011-04-08 02:26:24 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-04-08 03:21:00 PDT
http://trac.webkit.org/changeset/83272 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/inspector/resource-har-conversion.html http/tests/inspector/resource-parameters.html
Note You need to log in before you can comment on or make changes to this bug.