Bug 58117 – Incoming source should be preload scanned when the parser is blocked

• Component: Page Loading
• Status: RESOLVED FIXED

[Antti Koivisto]

Currently we append to the scanner but don't actually scan.

[Antti Koivisto]

Created attachment 88781 [details]
patch

[Adam Barth]

Comment on attachment 88781 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88781&action=review

> LayoutTests/ChangeLog:-9650
> ->>>>>>> .r82178

This change looks suspicious.  :)

> LayoutTests/http/tests/loading/preload-append-scan.php:18
> +usleep(200000);

Does this test really take 20 seconds to run?

[Adam Barth]

tonyg, would you be willing to review this patch?

[Antti Koivisto]

(In reply to comment #2)
> > +usleep(200000);
> 
> Does this test really take 20 seconds to run?

200ms

[Adam Barth]

> 200ms

I'm really too tired to be commenting in bugs.  :)

[Tony Gentilcore]

Comment on attachment 88781 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88781&action=review

This looks good, but we are starting to get a lot of entry points for scanning. I'm wondering if we shouldn't fix bug 57376, then always kick off the preload scanner first thing in insert() and append() (and nowhere else).

> LayoutTests/http/tests/resources/slow-script.pl:1
> +#!/usr/bin/perl -w

Is it possible to avoid adding a new resource and instead reuse misc/resources/script-slow1.pl?

[Antti Koivisto]

http://trac.webkit.org/changeset/83321

[WebKit Review Bot]

http://trac.webkit.org/changeset/83321 might have broken Qt Linux Release
The following tests are not passing:
http/tests/loading/preload-append-scan.php