Bug 58110

Summary:

[Chromium] Remove unneeded usage of V8::Lockers in IDB tests.

Product:

WebKit

Reporter:

Dmitry Titov <dimich>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aa, abarth, bulach

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch.	abarth: review+, dimich: commit-queue-

Dmitry Titov

Reported 2011-04-07 18:24:28 PDT

Since webkit_unit_tests are not running v8 on multiple threads, there is no need to use v8::Locker class. The problem with using it once is that every other test that runs late in the same process has to acquire a v8 lock too. Tests normally do not do that so they fail, especially on randomized runs. This will make the patch in bug 58096 not needed.

Attachments
Patch. (1.24 KB, patch) 2011-04-07 18:31 PDT, Dmitry Titov	abarth: review+ dimich: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dmitry Titov

Comment 1 2011-04-07 18:31:13 PDT

Created attachment 88751 [details] Patch.

Dmitry Titov

Comment 2 2011-04-08 13:11:23 PDT

Landed: http://trac.webkit.org/changeset/83331

Note You need to log in before you can comment on or make changes to this bug.