Summary: | [CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||||||
Component: | Canvas | Assignee: | Matthew Delaney <mdelaney7> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cmarrin, dglazkov, mdelaney7, simon.fraser, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 58088 | ||||||||||||
Attachments: |
|
Description
Matthew Delaney
2011-04-07 14:52:48 PDT
Created attachment 88846 [details]
Patch
EWS bots likely couldn't patch because of the xcodeproj file changing in the interim. I'm going to try again on the EWS bots by uploading the same patch again (after an update). If they just fail again (likely), I'll give it a run this evening when traffic is hopefully slower. I'm unsure of the project file changes needed for other projects and am pretty sure that the refactoring may need extra changes on other projects anyhow. Created attachment 88887 [details]
Patch
Attachment 88887 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8377184 Created attachment 89485 [details]
Patch
Created attachment 89490 [details]
Patch
Comment on attachment 89490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89490&action=review > Source/WebCore/platform/graphics/ImageBufferData.h:44 > +#if (PLATFORM(MAC) && PLATFORM(CA) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)) > +#define WTF_USE_IOSURFACE_CANVAS_BACKING_STORE 1 > +#endif Shouldn't this be in ImageBufferCG.h? > > +#if (PLATFORM(MAC) && PLATFORM(CA) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD))
> > +#define WTF_USE_IOSURFACE_CANVAS_BACKING_STORE 1
> > +#endif
>
> Shouldn't this be in ImageBufferCG.h?
It was in ImageBuffer.h because it was need there and below. I suppose since it's more specific to CG land and it wouldn't hurt, I'll just move it to ImageBufferCG.h.
Committed r83786: <http://trac.webkit.org/changeset/83786> |