Bug 58074

Summary: dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, eric, ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 57743    
Attachments:
Description Flags
converted the tests
none
removed extra script tags
none
58074 tony: review+

Ryosuke Niwa
Reported 2011-04-07 13:27:26 PDT
The following tests should be converted to dump-as-markup / dump-as-text tests: editing/pasteboard/5065605.html expected editing/pasteboard/display-block-on-spans.html
Attachments
converted the tests (40.32 KB, patch)
2011-04-07 13:59 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
removed extra script tags (39.95 KB, patch)
2011-04-07 14:01 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
58074 (39.96 KB, patch)
2011-04-07 14:06 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-04-07 13:59:02 PDT
Created attachment 88690 [details] converted the tests
Ryosuke Niwa
Comment 2 2011-04-07 14:01:41 PDT
Created attachment 88691 [details] removed extra script tags
Ryosuke Niwa
Comment 3 2011-04-07 14:06:19 PDT
Created attachment 88693 [details] 58074
Tony Chang
Comment 4 2011-04-07 15:13:00 PDT
Comment on attachment 88693 [details] 58074 View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review > LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4 > +The following two results must be visually identical. Might want to note that they are identical except for the caret. > LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34 > +| "This<#selection-caret>" > +| <b> > +| " is another paragraph." FWIW, it's not as easy to tell that this is visually the same. In particular, the  is confusing.
Ryosuke Niwa
Comment 5 2011-04-07 15:18:28 PDT
Comment on attachment 88693 [details] 58074 View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review Thanks for the review. >> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4 > > Might want to note that they are identical except for the caret. Good point. >> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34 >> +| " is another paragraph." > > FWIW, it's not as easy to tell that this is visually the same. In particular, the  is confusing. Yeah, we should probably convert non-breaking spaces by &nbsp; in dump-as-markup.js. That should be a separate patch though. Hopefully, most of people are aware that it's nbsp.
Ryosuke Niwa
Comment 6 2011-04-08 00:53:25 PDT
Committed r83268: <http://trac.webkit.org/changeset/83268>
Note You need to log in before you can comment on or make changes to this bug.