Summary: | URLs accessed as a result of pushState/replaceState should count as "visited" and be in the global history | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | History | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kbalazs, ossy, sam, zoltan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brady Eidson
2011-04-07 13:16:13 PDT
Created attachment 88678 [details]
Example showing bug (links should get visited, and should show up in Safari's history menu)
Created attachment 89131 [details]
Patch v1
Comment on attachment 89131 [details]
Patch v1
r=me
The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html (In reply to comment #6) > The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html Interesting. Seems possible/likely that WK2 DRT doesn't do history tracking properly yet. (In reply to comment #7) > (In reply to comment #6) > > The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html > > Interesting. Seems possible/likely that WK2 DRT doesn't do history tracking properly yet. WKTR does implement all of the related APIs, but it's returning the green unvisited link style, if I throw some alerts in. I tested the patch and test manually in WK2, so I know there's nothing fundamentally wrong here. I wonder if visited links round trip through the UI process and therefore we're getting hurt by IPC? I don't know yet, still exploring. (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > The new fast/loader/stateobjects/state-url-sets-links-visited.html fails on WK2 bot: > > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r83558%20%2810595%29/fast/loader/stateobjects/state-url-sets-links-visited-pretty-diff.html > > > > Interesting. Seems possible/likely that WK2 DRT doesn't do history tracking properly yet. > > WKTR does implement all of the related APIs, but it's returning the green unvisited link style, if I throw some alerts in. > > I tested the patch and test manually in WK2, so I know there's nothing fundamentally wrong here. I wonder if visited links round trip through the UI process and therefore we're getting hurt by IPC? I don't know yet, still exploring. Found 3 other tests that rely on the same layout test controller APIs that were already skipped. FIled https://bugs.webkit.org/show_bug.cgi?id=58334 and added this test to the skipped list. |