Bug 58067 – Somehow about:blank gets into the icon database

• Component: Page Loading
• Status: RESOLVED FIXED

[Darin Adler]

Somehow about:blank gets into the icon database

[Darin Adler]

Created attachment 88729 [details]
Patch

[WebKit Review Bot]

Attachment 88729 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8347795

[WebKit Review Bot]

Attachment 88729 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8344972

[Darin Adler]

Created attachment 88836 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 88836 [details]
Patch

Rejecting attachment 88836 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
RLGoogle.cpp
Hunk #3 succeeded at 196 (offset 5 lines).
Hunk #4 succeeded at 204 (offset 5 lines).
Hunk #5 succeeded at 258 (offset 5 lines).
Hunk #6 succeeded at 370 (offset 5 lines).
Hunk #7 succeeded at 443 (offset 5 lines).
Hunk #8 succeeded at 883 (offset 5 lines).
patching file Source/WebCore/platform/KURLGooglePrivate.h
Hunk #1 succeeded at 91 (offset 1 line).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8505937

[Darin Adler]

Committed r85056: <http://trac.webkit.org/changeset/85056>

[Andy Estes]

Comment on attachment 88836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88836&action=review

> Source/WebCore/platform/KURL.cpp:705
> +        if (!protocol[i] || !isLetterMatchIgnoringCase(m_string[i], protocol[i]))

This is wrong for protocolIs(), since protocols can have non-letter characters (numbers, '+', '-' and '.') but isLetterMatchIgnoringCase() ASSERTs when the second-argument is not lowercase 'a' through 'z'.

[Darin Adler]

(In reply to comment #7)
> (From update of attachment 88836 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88836&action=review
> 
> > Source/WebCore/platform/KURL.cpp:705
> > +        if (!protocol[i] || !isLetterMatchIgnoringCase(m_string[i], protocol[i]))
> 
> This is wrong for protocolIs(), since protocols can have non-letter characters (numbers, '+', '-' and '.') but isLetterMatchIgnoringCase() ASSERTs when the second-argument is not lowercase 'a' through 'z'.

The protocolIs function works only for protocols that are all letters. Dave Kilzer filed a bug complaining about that already. I’ll find it.

[Darin Adler]

It's bug 61572.