Bug 58047

Summary: Web Inspector: remove "enabled" from the setBreakpoint protocol.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, seokju.kwon, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported Thursday, April 7, 2011 4:59:15 PM UTC
There should be no way to add disabled breakpoint. Patch to follow.
Attachments
Patch (29.94 KB, patch)
2011-04-07 10:29 PDT, Pavel Feldman
yurys: review+
Pavel Feldman
Comment 1 Thursday, April 7, 2011 6:29:12 PM UTC
Yury Semikhatsky
Comment 2 Thursday, April 7, 2011 6:41:21 PM UTC
Comment on attachment 88658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88658&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:123 > + breakpoint.debuggerId = breakpointData.debuggerId; Extract method. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:168 > + if (!sourceFile) Please remove this, it never happens. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274 > + this._breakpointAdded(breakpoint); New breakpoint set should be saved. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:339 > + this._removeBreakpointFromDebugger(breakpoint); please pass afterUpdate as a callback to _removeBreakpointFromDebugger > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:395 > + _breakpointRemoved: function(breakpoint) Please inline this method.
Pavel Feldman
Comment 3 Thursday, April 7, 2011 7:25:14 PM UTC
Note You need to log in before you can comment on or make changes to this bug.