Bug 58047

Summary:

Web Inspector: remove "enabled" from the setBreakpoint protocol.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, seokju.kwon, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Description Pavel Feldman 2011-04-07 08:59:15 PDT

There should be no way to add disabled breakpoint. Patch to follow.

Comment 1 Pavel Feldman 2011-04-07 10:29:12 PDT

Created attachment 88658 [details]
Patch

Comment 2 Yury Semikhatsky 2011-04-07 10:41:21 PDT

Comment on attachment 88658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88658&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:123
> +                breakpoint.debuggerId = breakpointData.debuggerId;

Extract method.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:168
> +        if (!sourceFile)

Please remove this, it never happens.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274
> +            this._breakpointAdded(breakpoint);

New breakpoint set should be saved.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:339
> +            this._removeBreakpointFromDebugger(breakpoint);

please pass afterUpdate as a callback to _removeBreakpointFromDebugger

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:395
> +    _breakpointRemoved: function(breakpoint)

Please inline this method.

Comment 3 Pavel Feldman 2011-04-07 11:25:14 PDT

Committed r83190: <http://trac.webkit.org/changeset/83190>