Bug 58026

Summary: Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. pfeldman: review+

Description Pavel Podivilov 2011-04-07 03:26:57 PDT
Web Inspector: make SourceFrame TextViewer's delegate for editing operations.

This is the first step of decoupling TextViewer from SourceFrame (see https://bugs.webkit.org/show_bug.cgi?id=57941).
Comment 1 Pavel Podivilov 2011-04-07 03:27:46 PDT
Created attachment 88603 [details]
Patch.
Comment 2 Pavel Feldman 2011-04-07 08:49:13 PDT
Comment on attachment 88603 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=88603&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:229
> +        if (!this._delegate.contentEditable())

isContentEditable.
Comment 3 Pavel Podivilov 2011-04-08 05:32:24 PDT
Committed r83288: <http://trac.webkit.org/changeset/83288>