Bug 58026 - Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
Summary: Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 03:26 PDT by Pavel Podivilov
Modified: 2011-04-08 05:32 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (12.51 KB, patch)
2011-04-07 03:27 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-04-07 03:26:57 PDT 
Web Inspector: make SourceFrame TextViewer's delegate for editing operations.

This is the first step of decoupling TextViewer from SourceFrame (see https://bugs.webkit.org/show_bug.cgi?id=57941).
Comment 1 Pavel Podivilov 2011-04-07 03:27:46 PDT 
Created attachment 88603 [details]
Patch.
Comment 2 Pavel Feldman 2011-04-07 08:49:13 PDT 
Comment on attachment 88603 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=88603&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:229
> +        if (!this._delegate.contentEditable())

isContentEditable.
Comment 3 Pavel Podivilov 2011-04-08 05:32:24 PDT 
Committed r83288: <http://trac.webkit.org/changeset/83288>