Bug 58011

Summary:

Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

58010

Attachments:

Description	Flags
patch	mnaganov: commit-queue-
reduce test running time (bug 58010)	mnaganov: commit-queue-
split big test into smaller ones	pfeldman: review+, mnaganov: commit-queue-

Mikhail Naganov

Reported 2011-04-06 22:08:36 PDT

Added tests for "Containment" view. Minor refactorings, bugs fixed.

Attachments
patch (27.56 KB, patch) 2011-04-06 22:12 PDT, Mikhail Naganov	mnaganov: commit-queue-	Details Formatted Diff Diff
reduce test running time (bug 58010) (35.13 KB, patch) 2011-04-07 00:01 PDT, Mikhail Naganov	mnaganov: commit-queue-	Details Formatted Diff Diff
split big test into smaller ones (63.16 KB, patch) 2011-04-07 02:17 PDT, Mikhail Naganov	pfeldman: review+ mnaganov: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2011-04-06 22:12:28 PDT

Created attachment 88573 [details] patch

Mikhail Naganov

Comment 2 2011-04-07 00:01:49 PDT

Created attachment 88579 [details] reduce test running time (bug 58010)

Mikhail Naganov

Comment 3 2011-04-07 02:17:21 PDT

Created attachment 88596 [details] split big test into smaller ones

Mikhail Naganov

Comment 4 2011-04-08 04:59:51 PDT

Manually committed http://trac.webkit.org/changeset/83286 2011-04-08 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI. https://bugs.webkit.org/show_bug.cgi?id=58010 https://bugs.webkit.org/show_bug.cgi?id=58011 Added tests for "Containment" view. Minor refactorings, bugs fixed. Split one large tests into smaller ones to avoid timing out in debug mode. Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html inspector/profiler/detailed-heapshots-containment-show-all.html inspector/profiler/detailed-heapshots-containment-show-next.html inspector/profiler/detailed-heapshots-containment-sorting.html inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html inspector/profiler/detailed-heapshots-summary-show-all.html inspector/profiler/detailed-heapshots-summary-show-next.html inspector/profiler/detailed-heapshots-summary-sorting.html * inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotInstanceNode): (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDominatorObjectNode): * inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotContainmentDataGrid): (WebInspector.HeapSnapshotDominatorsDataGrid): 2011-04-08 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI. https://bugs.webkit.org/show_bug.cgi?id=58010 https://bugs.webkit.org/show_bug.cgi?id=58011 Added tests for "Containment" view. Minor refactorings, bugs fixed. Split one large tests into smaller ones to avoid timing out in debug mode. * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added. * inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added. * inspector/profiler/detailed-heapshots-containment-show-all.html: Added. * inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added. * inspector/profiler/detailed-heapshots-containment-show-next.html: Added. * inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-containment-sorting.html: Added. * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added. * inspector/profiler/detailed-heapshots-summary-expected.txt: Removed. * inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added. * inspector/profiler/detailed-heapshots-summary-show-all.html: Added. * inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added. * inspector/profiler/detailed-heapshots-summary-show-next.html: Added. * inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-summary-sorting.html: Added. * inspector/profiler/detailed-heapshots-summary.html: Removed. * inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled): (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest): (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest): * platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt. * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt. * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added. * platform/chromium/test_expectations.txt:

Note You need to log in before you can comment on or make changes to this bug.