Summary: | clearIfComposited call is really slow | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Bauman <jbauman> | ||||||
Component: | WebGL | Assignee: | John Bauman <jbauman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, commit-queue, kbr | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
John Bauman
2011-04-06 16:58:55 PDT
Created attachment 88544 [details]
Patch
Comment on attachment 88544 [details]
Patch
Looks good.
Comment on attachment 88544 [details] Patch Rejecting attachment 88544 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2 Last 500 characters of output: LayoutTestControllerQt.cpp M Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp M Tools/ChangeLog r83137 = 7f2c250c078454d645915dace97b96aef2626877 (refs/remotes/trunk) M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/DumpRenderTree/LayoutTestController.cpp M Tools/DumpRenderTree/LayoutTestController.h M Tools/ChangeLog r83138 = 8fef0c2b86f5af6c92684d29e9b2e11bf6f5822f (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8348429 You need to take out the "No new tests. OOPS!" line from your ChangeLog. Could you upload a new patch? Created attachment 88684 [details]
Fix patch
Comment on attachment 88684 [details]
Fix patch
Looks good.
Comment on attachment 88684 [details] Fix patch Clearing flags on attachment: 88684 Committed r83242: <http://trac.webkit.org/changeset/83242> All reviewed patches have been landed. Closing bug. |