Summary: | WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||||
Component: | WebKit2 | Assignee: | Chang Shu <cshu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Chang Shu
2011-04-06 14:31:47 PDT
Created attachment 88514 [details]
fix patch
Comment on attachment 88514 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=88514&action=review > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:183 > + return ""; I suggest String() instead of "". > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:186 > + return PrintContext::pageSizeAndMarginsInPixels(coreFrame, pageIndex, width, height, > + marginTop, marginRight, marginBottom, marginLeft); We don’t line up lines like this in WebKit. I suggest either doing a 4 pixel indent rather than lining things up or just putting all the arguments into one line. Created attachment 88551 [details]
r+ed patch with minor changes based on review
Comment on attachment 88551 [details] r+ed patch with minor changes based on review Clearing flags on attachment: 88551 Committed r83139: <http://trac.webkit.org/changeset/83139> All reviewed patches have been landed. Closing bug. |