Bug 57984

Summary: WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
Product: WebKit Reporter: Chang Shu <cshu>
Component: WebKit2Assignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
fix patch
darin: review+
r+ed patch with minor changes based on review none

Chang Shu
Reported 2011-04-06 14:31:47 PDT
failing printing/page-format-data-display-none.html
Attachments
fix patch (9.10 KB, patch)
2011-04-06 14:35 PDT, Chang Shu 		darin: review+
DetailsFormatted DiffDiff
r+ed patch with minor changes based on review (9.09 KB, patch)
2011-04-06 18:00 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-04-06 14:35:07 PDT
Created attachment 88514 [details] fix patch
Darin Adler
Comment 2 2011-04-06 17:16:53 PDT
Comment on attachment 88514 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=88514&action=review > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:183 > + return ""; I suggest String() instead of "". > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:186 > + return PrintContext::pageSizeAndMarginsInPixels(coreFrame, pageIndex, width, height, > + marginTop, marginRight, marginBottom, marginLeft); We don’t line up lines like this in WebKit. I suggest either doing a 4 pixel indent rather than lining things up or just putting all the arguments into one line.
Chang Shu
Comment 3 2011-04-06 18:00:34 PDT
Created attachment 88551 [details] r+ed patch with minor changes based on review
WebKit Commit Bot
Comment 4 2011-04-06 21:00:23 PDT
Comment on attachment 88551 [details] r+ed patch with minor changes based on review Clearing flags on attachment: 88551 Committed r83139: <http://trac.webkit.org/changeset/83139>
WebKit Commit Bot
Comment 5 2011-04-06 21:00:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.