Bug 57974

Summary: [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Minor CC: benjamin, commit-queue, kling, vestbo
Priority: P4 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch.
none
V2 with changelog's typo fixed. none

Alexis Menard (darktears)
Reported 2011-04-06 13:01:18 PDT
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA), it sounds better and is aligned with what the others do.
Attachments
Proposed patch. (15.94 KB, patch)
2011-04-06 13:03 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
V2 with changelog's typo fixed. (15.94 KB, patch)
2011-04-06 13:07 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-04-06 13:03:32 PDT
Created attachment 88495 [details] Proposed patch.
Alexis Menard (darktears)
Comment 2 2011-04-06 13:07:11 PDT
Created attachment 88496 [details] V2 with changelog's typo fixed.
Andreas Kling
Comment 3 2011-04-06 13:09:02 PDT
Comment on attachment 88496 [details] V2 with changelog's typo fixed. Good idea.
WebKit Commit Bot
Comment 4 2011-04-06 15:17:31 PDT
Comment on attachment 88496 [details] V2 with changelog's typo fixed. Clearing flags on attachment: 88496 Committed r83108: <http://trac.webkit.org/changeset/83108>
WebKit Commit Bot
Comment 5 2011-04-06 15:17:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.