Summary: | AVF: MediaPlayerPrivateAVFoundation never reaches playable state. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Jer Noble
2011-04-06 10:51:30 PDT
Created attachment 88516 [details]
Patch
Comment on attachment 88516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review r=me > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-634 > - LOG(Media, "MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) - notification %d", this, static_cast<int>(type)); Why remove this log call? Looks like it got copied to the new overload only, which seems a bit odd. (In reply to comment #3) > (From update of attachment 88516 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review > > r=me > > > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-634 > > - LOG(Media, "MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) - notification %d", this, static_cast<int>(type)); > > Why remove this log call? Looks like it got copied to the new overload only, which seems a bit odd. The two other scheduleMainThreadNotification() functions (the one taking a float, and the one taking a bool) funnel into this one (which takes a full blown Notification), so the LOG message is effectively called from each. Thanks! Committed r83196: <http://trac.webkit.org/changeset/83196> |