Bug 57949

Summary: Web Inspector: get rid of Breakpoint.js.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Work in progress.
none
Patch
none
Patch yurys: review+

Description Pavel Feldman 2011-04-06 08:00:40 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-06 08:02:27 PDT
Created attachment 88418 [details]
[PATCH] Work in progress.
Comment 2 Pavel Feldman 2011-04-07 05:40:51 PDT
Created attachment 88611 [details]
Patch
Comment 3 Pavel Podivilov 2011-04-07 06:09:26 PDT
Comment on attachment 88611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88611&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:323
> +            var scriptLocation = breakpoint.location ? breakpoint.location : {lineNumber:breakpoint.lineNumber, columnNumber:0};

Here breakpoint.lineNumber may denote location in formatter script. We should not map it in that case.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:371
> +            var pendingBreakpoints = this._breakpointsWithoutSourceFile[sourceFileId];

Please mind that sourceFileId would be undefined for all breakpoints created with the old version. When such breakpoints would be purged? Probably it's better to ignore them here?
Comment 4 Pavel Feldman 2011-04-07 07:40:51 PDT
Created attachment 88634 [details]
Patch
Comment 5 Pavel Podivilov 2011-04-07 08:01:38 PDT
(In reply to comment #4)
> Created an attachment (id=88634) [details]
> Patch

Looks good.
Comment 6 Pavel Feldman 2011-04-07 08:47:49 PDT
Committed r83176: <http://trac.webkit.org/changeset/83176>