| Summary: | [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jamie Cooley <james.cooley> | ||||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, webkit-ews, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jamie Cooley
2011-04-06 06:44:41 PDT
Created attachment 88411 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
Attachment 88411 [details] did not build on qt: Build output: http://queues.webkit.org/results/8343182 (In reply to comment #2) > Attachment 88411 [details] did not build on qt: > Build output: http://queues.webkit.org/results/8343182 OK, I will take a look at this. Comment on attachment 88411 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
R-, does not build :)
Make sure you check the checkbox "patch" when uploading a patch...
Created attachment 88636 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
And this one builds! ;)
Attachment 88636 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/qt/qwkhistory.h:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 88641 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
Comment on attachment 88641 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
Looks ok. I would have liked a comment in the Changelog about the change of qwkhistory.h but that is not important.
Comment on attachment 88641 [details] proposed patch to copy qwkhistory.h into includes/WebKit2 Clearing flags on attachment: 88641 Committed r83297: <http://trac.webkit.org/changeset/83297> All reviewed patches have been landed. Closing bug. |