Bug 57945

Summary: [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
Product: WebKit Reporter: Jamie Cooley <james.cooley>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, webkit-ews, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch to copy qwkhistory.h into includes/WebKit2
benjamin: review-
proposed patch to copy qwkhistory.h into includes/WebKit2
none
proposed patch to copy qwkhistory.h into includes/WebKit2 none

Jamie Cooley
Reported 2011-04-06 06:44:41 PDT
qwkpage, qwkpreferences were copied as of r72039; qwkhistory is not.
Attachments
proposed patch to copy qwkhistory.h into includes/WebKit2 (992 bytes, patch)
2011-04-06 06:57 PDT, Jamie Cooley 		benjamin: review-
DetailsFormatted DiffDiff
proposed patch to copy qwkhistory.h into includes/WebKit2 (1.47 KB, text/plain)
2011-04-07 07:48 PDT, Jamie Cooley 		no flags
Details
proposed patch to copy qwkhistory.h into includes/WebKit2 (1.74 KB, patch)
2011-04-07 08:16 PDT, Jamie Cooley 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jamie Cooley
Comment 1 2011-04-06 06:57:23 PDT
Created attachment 88411 [details] proposed patch to copy qwkhistory.h into includes/WebKit2
Early Warning System Bot
Comment 2 2011-04-06 07:08:41 PDT
Attachment 88411 [details] did not build on qt: Build output: http://queues.webkit.org/results/8343182
Jamie Cooley
Comment 3 2011-04-06 07:17:07 PDT
(In reply to comment #2) > Attachment 88411 [details] did not build on qt: > Build output: http://queues.webkit.org/results/8343182 OK, I will take a look at this.
Benjamin Poulain
Comment 4 2011-04-06 08:57:54 PDT
Comment on attachment 88411 [details] proposed patch to copy qwkhistory.h into includes/WebKit2 R-, does not build :) Make sure you check the checkbox "patch" when uploading a patch...
Jamie Cooley
Comment 5 2011-04-07 07:48:27 PDT
Created attachment 88636 [details] proposed patch to copy qwkhistory.h into includes/WebKit2 And this one builds! ;)
WebKit Review Bot
Comment 6 2011-04-07 07:49:43 PDT
Attachment 88636 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/qwkhistory.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jamie Cooley
Comment 7 2011-04-07 08:16:58 PDT
Created attachment 88641 [details] proposed patch to copy qwkhistory.h into includes/WebKit2
Benjamin Poulain
Comment 8 2011-04-08 07:03:00 PDT
Comment on attachment 88641 [details] proposed patch to copy qwkhistory.h into includes/WebKit2 Looks ok. I would have liked a comment in the Changelog about the change of qwkhistory.h but that is not important.
WebKit Commit Bot
Comment 9 2011-04-08 08:38:21 PDT
Comment on attachment 88641 [details] proposed patch to copy qwkhistory.h into includes/WebKit2 Clearing flags on attachment: 88641 Committed r83297: <http://trac.webkit.org/changeset/83297>
WebKit Commit Bot
Comment 10 2011-04-08 08:38:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.