Summary: | Add member functions for determining line/paragraph separation to InlineIterator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||||
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Levi Weintraub
2011-04-06 03:23:19 PDT
Created attachment 88392 [details]
Patch
Comment on attachment 88392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88392&action=review > Source/WebCore/rendering/InlineIterator.h:71 > + inline bool isHardTextLinebreak() Since this is a member function of an iterator, would atHardTextLinebreak makes more sense? But what does hard text line break really mean? Is this terminology used elsewhere? Maybe atPreservedLineBreak makes more sense? > Source/WebCore/rendering/InlineIterator.h:77 > + inline bool isParagraphSeparator() Ditto: s/is/at/ Comment on attachment 88392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88392&action=review >> Source/WebCore/rendering/InlineIterator.h:71 >> + inline bool isHardTextLinebreak() > > Since this is a member function of an iterator, would atHardTextLinebreak makes more sense? But what does hard text line break really mean? Is this terminology used elsewhere? Maybe atPreservedLineBreak makes more sense? At sounds fine. HardLineBreak is the terminology used in BidiResolver (see: createBidiRunsForLine). Though we don't yet support it, when we add support for Unicode Paragraph Separators (https://bugs.webkit.org/show_bug.cgi?id=53203), this won't just be applicable to preserved newline characters. How about atTextParagraphSeparator, as this is how it will be treated when running Unicode BiDi algorithm? Created attachment 88396 [details]
Patch
Comment on attachment 88396 [details] Patch Clearing flags on attachment: 88396 Committed r83038: <http://trac.webkit.org/changeset/83038> All reviewed patches have been landed. Closing bug. |