Bug 57932

Summary: [GTK] DumpRenderTree: do not try to free NULL SoupURIs
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mrobinson: review+

Description Sergio Villar Senin 2011-04-06 02:27:28 PDT
[GTK] DumpRenderTree: do not try to free NULL SoupURIs
Comment 1 Sergio Villar Senin 2011-04-06 02:31:11 PDT
Created attachment 88386 [details]
Patch
Comment 2 Philippe Normand 2011-04-06 04:58:13 PDT
Comment on attachment 88386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88386&action=review

Thanks for fixing this :)

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1057
> +    if (uri && SOUP_URI_VALID_FOR_HTTP(uri) && g_strcmp0(uri->host, "127.0.0.1")

SOUP_URI_VALID_FOR_HTTP() already checks the uri, so no need for that extra check I think.
Comment 3 Martin Robinson 2011-04-06 06:53:09 PDT
Comment on attachment 88386 [details]
Patch

Nice fix. If Philippe is correct, please remove the first check.
Comment 4 Sergio Villar Senin 2011-04-06 10:32:49 PDT
Committed r83068: <http://trac.webkit.org/changeset/83068>