Bug 57918

Summary: Add QUOTA build flag for unified quota API
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dmikurube, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 57927, 60355    
Attachments:
Description Flags
The first patch to add QUOTA flag
none
Patch levin: review+

Description Kinuko Yasuda 2011-04-05 22:04:34 PDT
Per public discussion on public-webapps, we need unified quota API that allows webapps to request/query the current storage usage and quota.  The spec is not fully specified yet and is subject to change, and the feature should be guarded by a new compile time flag.

http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
Comment 1 Dai Mikurube 2011-04-05 22:57:03 PDT
Created attachment 88369 [details]
The first patch to add QUOTA flag
Comment 2 Kinuko Yasuda 2011-04-05 23:41:23 PDT
Comment on attachment 88369 [details]
The first patch to add QUOTA flag

Thanks for working on this!

View in context: https://bugs.webkit.org/attachment.cgi?id=88369&action=review

Have you forgotten to add the similar change in configure.ac (and top level ChangeLog)?

> Source/WebCore/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube@google.com>

Different address from the one in others (chromium.org vs google.com).

> Source/WebCore/WebCore.pri:169
> +!contains(DEFINES, ENABLE_QUOTA=.): DEFINES += ENABLE_QUOTA=0 

Seems like we should put this in Source/WebCore/features.pri instead?

> Source/WebKit/chromium/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube@google.com>

ditto.

> Source/WebKit/chromium/features.gypi:78
> +        'ENABLE_QUOTA=1',

Please do not enable this yet.  (You can just remove this line for now)

> Source/WebKit/mac/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube@google.com>

ditto.

> WebKitLibraries/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube@google.com>

ditto.
Comment 3 Dai Mikurube 2011-04-05 23:58:29 PDT
Created attachment 88379 [details]
Patch
Comment 4 Dai Mikurube 2011-04-06 00:00:08 PDT
Thank you for your comments. Modified the patch.
Comment 5 Kinuko Yasuda 2011-04-06 00:16:50 PDT
Comment on attachment 88379 [details]
Patch

Thanks, looks good to me.
Comment 6 Kinuko Yasuda 2011-04-06 20:26:08 PDT
Committed r83133: <http://trac.webkit.org/changeset/83133>