Bug 57894

Summary: Rename variables in border drawing code for readability
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2011-04-05 15:40:29 PDT
Rename variables in border drawing code for readability
Attachments
Patch (24.15 KB, patch)
2011-04-05 15:41 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-04-05 15:41:04 PDT
Created attachment 88321 [details] Patch
WebKit Review Bot
Comment 2 2011-04-05 15:42:08 PDT
Attachment 88321 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 Source/WebCore/rendering/RenderObject.cpp:740: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files Source/WebCore/rendering/RenderObject.cpp:740: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2011-04-05 15:51:06 PDT
http://trac.webkit.org/changeset/82995
Note You need to log in before you can comment on or make changes to this bug.