Bug 57893

Summary: [Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit2Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch ap: review+

Description Darin Adler 2011-04-05 15:27:27 PDT
[MAC] WebKit2: Escape key does not stop page loads when focus is on the web page
Comment 1 Darin Adler 2011-04-05 15:28:08 PDT
<rdar://problem/9130486>
Comment 2 Darin Adler 2011-04-05 17:07:20 PDT
Created attachment 88337 [details]
Patch
Comment 3 Darin Adler 2011-04-05 17:07:59 PDT
Alexey, this is the bug you asked me to fix.
Comment 4 Alexey Proskuryakov 2011-04-05 17:30:59 PDT
Comment on attachment 88337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88337&action=review

> Source/WebKit2/UIProcess/PageClient.h:104
> +    virtual bool executeKeypressCommand(const String& selector) = 0;

Keypress may confuse someone into thinking that the command is executed when keypress is dispatched. But it's for keydown, as far as I can tell.
Comment 5 Darin Adler 2011-04-05 17:55:40 PDT
Committed r83004: <http://trac.webkit.org/changeset/83004>