Bug 57890
| Summary: | Hierarchy of renderers for elements with a document needs to be unified | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Marrin <cmarrin> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | zalan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Chris Marrin
Today, we have 3 elements which can contain an HTML document: HTMLIFrameElement, HTMLFrameElement and HTMLObjectElement. Their renderers are: RenderIFrame, RenderFrame and RenderEmbeddedObject, respectively. Their hierarchy is:
...
RenderPart
RenderEmbeddedObject
RenderFrameBase
RenderIFrame
RenderFrame
So common functionality has to go into RenderPart, which is really too broad. It would be better with an added class:
...
RenderPart
RenderFrameOwner
RenderEmbeddedObject
RenderFrameBase
RenderIFrame
RenderFrame
This more closely mimics the corresponding Element hierarchy and RenderFrameOwner would give us a place to put the common code.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |