Bug 57889

Summary: [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, mihaip, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2011-04-05 15:11:25 PDT
[chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
Attachments
Patch (4.11 KB, patch)
2011-04-05 15:12 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (3.66 KB, patch)
2011-04-05 18:39 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-04-05 15:12:08 PDT
Created attachment 88318 [details] Patch
Tony Chang
Comment 2 2011-04-05 15:13:46 PDT
Not sure if there's a better way to do this. Suggestions welcome. The problem was if we pass 'chromium-linux' to ChromiumLinuxPort.__init__, we automatically run self._determine_architecture. Instead, force x86 by passing in the architecture in part of the port name.
Dirk Pranke
Comment 3 2011-04-05 15:23:05 PDT
As I said over IRC, this is actually the right way to do this. The port names that get passed in by the rebaselining tool should be specific enough to unambiguously get a particular directory, and chromium-linux wasn't. It's the same reason we use 'chromium-win-win7' in this list instead of 'chromium-win'. Patch LGTM.
Mihai Parparita
Comment 4 2011-04-05 17:35:52 PDT
Comment on attachment 88318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88318&action=review > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:538 > + new_file, baseline_fullpath) Why the switch? copyfile takes source then destination.
Tony Chang
Comment 5 2011-04-05 18:39:56 PDT
Created attachment 88348 [details] Patch
Tony Chang
Comment 6 2011-04-05 18:40:03 PDT
Comment on attachment 88318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88318&action=review >> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:538 >> + new_file, baseline_fullpath) > > Why the switch? copyfile takes source then destination. Oh, you're right, it was correct. I was confused since it was copying the file to /tmp.
WebKit Commit Bot
Comment 7 2011-04-05 19:20:19 PDT
Comment on attachment 88348 [details] Patch Clearing flags on attachment: 88348 Committed r83009: <http://trac.webkit.org/changeset/83009>
WebKit Commit Bot
Comment 8 2011-04-05 19:20:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.