Bug 57889

Summary: [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, mihaip, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Tony Chang 2011-04-05 15:11:25 PDT 
[chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
Comment 1 Tony Chang 2011-04-05 15:12:08 PDT 
Created attachment 88318 [details]
Patch
Comment 2 Tony Chang 2011-04-05 15:13:46 PDT 
Not sure if there's a better way to do this.  Suggestions welcome.

The problem was if we pass 'chromium-linux' to ChromiumLinuxPort.__init__, we automatically run self._determine_architecture.  Instead, force x86 by passing in the architecture in part of the port name.
Comment 3 Dirk Pranke 2011-04-05 15:23:05 PDT 
As I said over IRC, this is actually the right way to do this. The port names that get passed in by the rebaselining tool should be specific enough to unambiguously get a particular directory, and chromium-linux wasn't. It's the same reason we use 'chromium-win-win7' in this list instead of 'chromium-win'.

Patch LGTM.
Comment 4 Mihai Parparita 2011-04-05 17:35:52 PDT 
Comment on attachment 88318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88318&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:538
> +                  new_file, baseline_fullpath)

Why the switch? copyfile takes source then destination.
Comment 5 Tony Chang 2011-04-05 18:39:56 PDT 
Created attachment 88348 [details]
Patch
Comment 6 Tony Chang 2011-04-05 18:40:03 PDT 
Comment on attachment 88318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88318&action=review

>> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:538
>> +                  new_file, baseline_fullpath)
> 
> Why the switch? copyfile takes source then destination.

Oh, you're right, it was correct.  I was confused since it was copying the file to /tmp.
Comment 7 WebKit Commit Bot 2011-04-05 19:20:19 PDT 
Comment on attachment 88348 [details]
Patch

Clearing flags on attachment: 88348

Committed r83009: <http://trac.webkit.org/changeset/83009>
Comment 8 WebKit Commit Bot 2011-04-05 19:20:23 PDT 
All reviewed patches have been landed.  Closing bug.