Bug 57846

Summary:

ORWT shouldn't generate diff files for tests without expected files

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, jhoneycutt, mrowe, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed fix	none

Csaba Osztrogonác

Reported 2011-04-05 07:38:12 PDT

Now old-run-webkit-tests creates a zero sized actual-result.txt, and then generate a useless diff and a pretty diff file for all tests without checked in expected file. The original changeset was: http://trac.webkit.org/changeset/46607

Attachments
proposed fix (1.45 KB, patch) 2011-04-05 07:43 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2011-04-05 07:43:40 PDT

Created attachment 88231 [details] proposed fix With this modification won't break the original goal of http://trac.webkit.org/changeset/46607 , links to the new test results will work, but we shouldn't generate useless zero bytes sized expected.txt and a diff and pretty diff file.

Csaba Osztrogonác

Comment 2 2011-04-05 07:46:22 PDT

Comment on attachment 88231 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=88231&action=review > Tools/Scripts/old-run-webkit-tests:2113 > + if ( !-f $expectedResultPath) { ooops, an additional space typo. I'm going to fix it before landing.

Andras Becsi

Comment 3 2011-04-06 07:56:38 PDT

Comment on attachment 88231 [details] proposed fix LGTM.

Csaba Osztrogonác

Comment 4 2011-04-06 08:49:06 PDT

Landed in http://trac.webkit.org/changeset/83055

WebKit Review Bot

Comment 5 2011-04-06 09:07:58 PDT

http://trac.webkit.org/changeset/83055 might have broken WinCairo Debug (Build)

Note You need to log in before you can comment on or make changes to this bug.