Bug 57846

Summary:

ORWT shouldn't generate diff files for tests without expected files

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, jhoneycutt, mrowe, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed fix	none

Description Csaba Osztrogonác 2011-04-05 07:38:12 PDT

Now old-run-webkit-tests creates a zero sized actual-result.txt,
and then generate a useless diff and a pretty diff file for all
tests without checked in expected file.

The original changeset was: http://trac.webkit.org/changeset/46607

Comment 1 Csaba Osztrogonác 2011-04-05 07:43:40 PDT

Created attachment 88231 [details]
proposed fix

With this modification won't break the original goal of
http://trac.webkit.org/changeset/46607 , links to the new 
test results will work, but we shouldn't generate useless 
zero bytes sized expected.txt and a diff and pretty diff file.

Comment 2 Csaba Osztrogonác 2011-04-05 07:46:22 PDT

Comment on attachment 88231 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=88231&action=review

> Tools/Scripts/old-run-webkit-tests:2113
> +    if ( !-f $expectedResultPath) {

ooops, an additional space typo. I'm going to fix it before landing.

Comment 3 Andras Becsi 2011-04-06 07:56:38 PDT

Comment on attachment 88231 [details]
proposed fix

LGTM.

Comment 4 Csaba Osztrogonác 2011-04-06 08:49:06 PDT

Landed in http://trac.webkit.org/changeset/83055

Comment 5 WebKit Review Bot 2011-04-06 09:07:58 PDT

http://trac.webkit.org/changeset/83055 might have broken WinCairo Debug (Build)