Bug 57837

Summary: Switch from Vector<UChar> to StringBuilder in accessibility/
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch v2 kling: review+

Nikolas Zimmermann
Reported 2011-04-05 06:09:14 PDT
As discussed in bug 56099, we should deploy StringBuilder usage in WebCore where possible. This bug addresses Source/WebCore/accessibility.
Attachments
Patch (5.08 KB, patch)
2011-04-05 06:11 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (5.28 KB, patch)
2011-04-05 06:22 PDT, Nikolas Zimmermann 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-04-05 06:11:54 PDT
Created attachment 88214 [details] Patch
WebKit Review Bot
Comment 2 2011-04-05 06:16:43 PDT
Attachment 88214 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8334317
Nikolas Zimmermann
Comment 3 2011-04-05 06:22:54 PDT
Created attachment 88216 [details] Patch v2 Fix missing include, hard to notice on mac which does AllInOne builds.
Andreas Kling
Comment 4 2011-04-05 06:28:43 PDT
Comment on attachment 88216 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=88216&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1185 > String nameFragment = accessibleNameForNode(idElement); Seems like we don't need this local anymore.
Nikolas Zimmermann
Comment 5 2011-04-05 06:38:30 PDT
Fixed Andreas suggestion! Landed in r82934.
Note You need to log in before you can comment on or make changes to this bug.