Summary: | Web Inspector: Range insertNode function does not update content in the inspector | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2011-04-05 05:08:03 PDT
Created attachment 88227 [details]
[PATCH] Suggested fix
Created attachment 88234 [details]
[PATCH] Added a test case to an existing test instead of a new one
Created attachment 88252 [details]
[PATCH] Simplified patch, as suggested by pfeldman
Comment on attachment 88252 [details] [PATCH] Simplified patch, as suggested by pfeldman View in context: https://bugs.webkit.org/attachment.cgi?id=88252&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1100 > + m_childrenRequested.add(bind(container, nodesMap)); Please remove all the other calls to m_childredRequested.add Created attachment 88267 [details]
[PATCH] Comment addressed
Comment on attachment 88267 [details] [PATCH] Comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=88267&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1094 > + return buildArrayForContainerChildren(container, 1, nodesMap); Can you rewrite this if block to avoid the recursive call here? Committed r83037: <http://trac.webkit.org/changeset/83037> |