Bug 57810

Summary:

[V8] Keep dirty primitive CSS values alive

Product:

WebKit

Reporter:

Vitaly Repeshko <vitalyr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, antonm

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	abarth: review+

Description Vitaly Repeshko 2011-04-04 17:35:20 PDT

[V8] Keep dirty primitive CSS values alive

This should make fast/dom/StyleSheet/gc-inline-style-cssvalues.html pass again.

Comment 1 Vitaly Repeshko 2011-04-04 17:41:53 PDT

Created attachment 88174 [details]
patch

Comment 2 anton muhin 2011-04-05 02:27:40 PDT

Comment on attachment 88174 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88174&action=review

LGTM

> Source/WebCore/bindings/v8/V8GCController.cpp:368
> +                Vector<v8::Persistent<v8::Value> > values;

nit: may you add a space between < and v8::Persistent?

Comment 3 Vitaly Repeshko 2011-04-05 14:20:53 PDT

	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/chromium/test_expectations.txt
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/bindings/v8/V8GCController.cpp
Committed r82981