|Summary:||HTML5 Player Has no Fullscreen Mode|
|Product:||WebKit||Reporter:||Jer Noble <jer.noble>|
|Component:||Media||Assignee:||Jer Noble <jer.noble>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Jer Noble 2011-04-04 15:15:18 PDT
Comment 3 Darin Adler 2011-04-04 16:46:19 PDT
Comment on attachment 88142 [details] Patch Is there an easy way to regression-test this?
Comment 4 Jer Noble 2011-04-05 08:54:27 PDT
(In reply to comment #3) > (From update of attachment 88142 [details]) > Is there an easy way to regression-test this? Not really; we'd have to convince DRT to answer "false" to supportsFullscreenForNode(), and "true" to supportsFullscreenForElement(), which would break a lot of existing tests on platforms which don't support the new API.
Comment 5 Jer Noble 2011-04-05 08:54:59 PDT
OTOH, I have a bug which would add support for the new API to WebKitTestRunner, and once that's fixed, this would be easily regression testable.
Comment 7 WebKit Commit Bot 2011-04-05 15:23:35 PDT
Comment on attachment 88142 [details] Patch Clearing flags on attachment: 88142 Committed r82991: <http://trac.webkit.org/changeset/82991>
Comment 8 WebKit Commit Bot 2011-04-05 15:23:40 PDT
All reviewed patches have been landed. Closing bug.