Bug 57763

Summary: Web Inspector: [Extensions API] remove inspectedPage.* events
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
yurys: review-
patch yurys: review+

Andrey Kosyakov
Reported 2011-04-04 10:23:45 PDT
- remove onDOMContentLoaded & onLoaded events (native browser extensions should be used instead) - moved onNavigated to webInspecor.resources
Attachments
patch (8.71 KB, patch)
2011-04-04 10:31 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
patch (12.77 KB, patch)
2011-04-05 09:29 PDT, Andrey Kosyakov 		yurys: review-
DetailsFormatted DiffDiff
patch (12.64 KB, patch)
2011-04-05 10:08 PDT, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2011-04-04 10:31:21 PDT
Created attachment 88077 [details] patch
Yury Semikhatsky
Comment 2 2011-04-05 01:35:36 PDT
Comment on attachment 88077 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=88077&action=review > Source/WebCore/inspector/front-end/ExtensionAPI.js:114 > + this.onNavigated = new EventSink("inspectedURLChanged"); Is there a test for this event? > Source/WebCore/inspector/front-end/ExtensionAPISchema.json:170 > + "name": "callback", Looks unrelated to this change.
Andrey Kosyakov
Comment 3 2011-04-05 09:29:27 PDT
Created attachment 88253 [details] patch - the schema change is intended (just a drive-by fix to bring it in-sync with the code) - added test
Yury Semikhatsky
Comment 4 2011-04-05 09:59:59 PDT
Comment on attachment 88253 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=88253&action=review > LayoutTests/inspector/extensions/extensions-events-expected.txt:8 > +Navigated to: file:///E:/src/gchromium/src/third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html?navigated Test result is source-path dependent, r- for this.
Andrey Kosyakov
Comment 5 2011-04-05 10:08:00 PDT
Created attachment 88266 [details] patch oops, thanks for spotting this!
Andrey Kosyakov
Comment 6 2011-04-06 01:27:28 PDT
Manually committed r83033: http://trac.webkit.org/changeset/83033
Note You need to log in before you can comment on or make changes to this bug.