Summary: | Web Inspector: [Extensions API] remove inspectedPage.* events | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Andrey Kosyakov
2011-04-04 10:23:45 PDT
Created attachment 88077 [details]
patch
Comment on attachment 88077 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=88077&action=review > Source/WebCore/inspector/front-end/ExtensionAPI.js:114 > + this.onNavigated = new EventSink("inspectedURLChanged"); Is there a test for this event? > Source/WebCore/inspector/front-end/ExtensionAPISchema.json:170 > + "name": "callback", Looks unrelated to this change. Created attachment 88253 [details]
patch
- the schema change is intended (just a drive-by fix to bring it in-sync with the code)
- added test
Comment on attachment 88253 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=88253&action=review > LayoutTests/inspector/extensions/extensions-events-expected.txt:8 > +Navigated to: file:///E:/src/gchromium/src/third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html?navigated Test result is source-path dependent, r- for this. Created attachment 88266 [details]
patch
oops, thanks for spotting this!
Manually committed r83033: http://trac.webkit.org/changeset/83033 |