Bug 57749

Summary: Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Andrey Adaikin
Reported 2011-04-04 02:52:13 PDT
Search tokens may not be shown if the editor is busy with highlighting the lines (i.e. scrollIntoViewIfNeeded() is not called).
Attachments
Patch (4.40 KB, patch)
2011-04-04 04:25 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2011-04-04 04:25:51 PDT
Created attachment 88048 [details] Patch
Yury Semikhatsky
Comment 2 2011-04-04 05:17:44 PDT
Comment on attachment 88048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88048&action=review > Source/WebCore/inspector/front-end/TextViewer.js:1029 > + if (this._rangeToMark && this._rangeToMark.startLine === lineNumber) Consider refactoring this method and extracting syntax highlight and search result highlight into separate methods.
Pavel Podivilov
Comment 3 2011-04-04 05:40:23 PDT
Comment on attachment 88048 [details] Patch Clearing flags on attachment: 88048 Committed r82824: <http://trac.webkit.org/changeset/82824>
Pavel Podivilov
Comment 4 2011-04-04 05:40:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.