Bug 57726

Summary:

Teach InlineIterator how to work from any root, not just a RenderBlock

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, mitz, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

50912

Attachments:

Description	Flags
Patch	none

Description Eric Seidel (no email) 2011-04-03 03:19:44 PDT

Teach InlineIterator how to work from any root, not just a RenderBlock

Comment 1 Eric Seidel (no email) 2011-04-03 03:22:32 PDT

Created attachment 88003 [details]
Patch

Comment 2 Ryosuke Niwa 2011-04-03 03:57:20 PDT

Comment on attachment 88003 [details]
Patch

Doesn't InlineIterator currently assume to be working on RenderBlock?  It seems like we should assert that we're only passing RenderBlock before you make the behavioral change.

Comment 3 Eric Seidel (no email) 2011-04-03 04:03:38 PDT

It never uses it as a RenderBlock.  It's just a pointer to where to start/stop walking.

Comment 4 Ryosuke Niwa 2011-04-03 04:05:45 PDT

Comment on attachment 88003 [details]
Patch

I see. m_root is never used other than being compared with other pointers. Okay, the change looks sane to me.

Comment 5 WebKit Commit Bot 2011-04-03 05:38:00 PDT

Comment on attachment 88003 [details]
Patch

Clearing flags on attachment: 88003

Committed r82793: <http://trac.webkit.org/changeset/82793>

Comment 6 WebKit Commit Bot 2011-04-03 05:38:04 PDT

All reviewed patches have been landed.  Closing bug.