Summary: | Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nico Weber <thakis> | ||||||||
Component: | Platform | Assignee: | Nico Weber <thakis> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, dbates, jamesr | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Nico Weber
2011-04-02 18:16:20 PDT
Created attachment 87991 [details]
Patch
Created attachment 87993 [details]
Patch
Comment on attachment 87993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87993&action=review > Source/WebCore/ChangeLog:12 > + Expclicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0 > + https://bugs.webkit.org/show_bug.cgi?id=57715 > + > + * platform/text/LocalizedNumberICU.cpp: > + (WebCore::createFormatterForCurrentLocale): > + (WebCore::numberFormatter): > + (WebCore::parseLocalizedNumber): > + (WebCore::formatLocalizedNumber): This ChangeLog doesn't tell me why you're making this change. I have no idea. Created attachment 87994 [details]
Patch
Comment on attachment 87994 [details] Patch Clearing flags on attachment: 87994 Committed r82787: <http://trac.webkit.org/changeset/82787> All reviewed patches have been landed. Closing bug. *** Bug 57714 has been marked as a duplicate of this bug. *** We don't normally use namespace prefixes in .cpp files, we put using directives in the beginning (e.g. "using namespace std;"). |