Bug 57715

Summary: Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0
Product: WebKit Reporter: Nico Weber <thakis>
Component: PlatformAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dbates, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nico Weber
Reported 2011-04-02 18:16:20 PDT
Expclicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0
Attachments
Patch (3.29 KB, patch)
2011-04-02 18:17 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2011-04-02 18:46 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (3.58 KB, patch)
2011-04-02 20:49 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-04-02 18:17:28 PDT
Created attachment 87991 [details] Patch
Nico Weber
Comment 2 2011-04-02 18:46:02 PDT
Created attachment 87993 [details] Patch
Adam Barth
Comment 3 2011-04-02 20:16:15 PDT
Comment on attachment 87993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87993&action=review > Source/WebCore/ChangeLog:12 > + Expclicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0 > + https://bugs.webkit.org/show_bug.cgi?id=57715 > + > + * platform/text/LocalizedNumberICU.cpp: > + (WebCore::createFormatterForCurrentLocale): > + (WebCore::numberFormatter): > + (WebCore::parseLocalizedNumber): > + (WebCore::formatLocalizedNumber): This ChangeLog doesn't tell me why you're making this change. I have no idea.
Nico Weber
Comment 4 2011-04-02 20:49:06 PDT
Created attachment 87994 [details] Patch
WebKit Commit Bot
Comment 5 2011-04-02 21:55:23 PDT
Comment on attachment 87994 [details] Patch Clearing flags on attachment: 87994 Committed r82787: <http://trac.webkit.org/changeset/82787>
WebKit Commit Bot
Comment 6 2011-04-02 21:55:28 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 7 2011-04-03 21:49:56 PDT
*** Bug 57714 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 8 2011-04-03 21:52:07 PDT
We don't normally use namespace prefixes in .cpp files, we put using directives in the beginning (e.g. "using namespace std;").
Nico Weber
Comment 9 2011-04-03 22:12:51 PDT
whoopsies: https://bugs.webkit.org/show_bug.cgi?id=57742
Note You need to log in before you can comment on or make changes to this bug.