Bug 57708

Summary: [Qt] Style fix for QtMobileWebStyle.h
Product: WebKit Reporter: Diego Gonzalez <diegohcg>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, menard, tonikitoo
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Diego Gonzalez 2011-04-02 12:07:54 PDT
Fix style drawControl and drawComplexControl prototype
Comment 1 Diego Gonzalez 2011-04-02 12:10:19 PDT
Created attachment 87983 [details]
Patch
Comment 2 Antonio Gomes 2011-04-03 19:32:42 PDT
Comment on attachment 87983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87983&action=review

> Source/WebCore/platform/qt/QtMobileWebStyle.h:31
> +    void drawControl(ControlElement, const QStyleOption*, QPainter*, const QWidget*) const;
> +    void drawComplexControl(ComplexControl, const QStyleOptionComplex*, QPainter*, const QWidget*) const;

You are changing the default value, diego. It goes beyond style fixes :)
Comment 3 Alexis Menard (darktears) 2011-04-04 05:34:39 PDT
So it's r- no?
Comment 4 Antonio Gomes 2011-04-04 07:20:12 PDT
(In reply to comment #3)
> So it's r- no?

Not necesseraly. No everything needs to be r- if the contributor is a committer and patch has an issue. I r+ and expressed my concern, so it is just a matter of fixing it before landing.
Comment 5 Antonio Gomes 2011-04-04 07:20:48 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > So it's r- no?
> 
> Not necesseraly. No everything needs to be r- if the contributor is a committer and patch has an issue. I r+ and expressed my concern, so it is just a matter of fixing it before landing.

Also it seems this default value is not used, since it did not break stuff to diego. So I do not really care this time.
Comment 6 Benjamin Poulain 2011-04-04 08:23:22 PDT
Comment on attachment 87983 [details]
Patch

Let's cq+...
Comment 7 WebKit Commit Bot 2011-04-04 08:26:53 PDT
Comment on attachment 87983 [details]
Patch

Rejecting attachment 87983 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/qt/QtMobileWebStyle.h
Hunk #1 FAILED at 27.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/qt/QtMobileWebStyle.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/8185955
Comment 8 Diego Gonzalez 2011-04-04 16:00:20 PDT
Thanks guys. I will commit it manually.
Comment 9 Diego Gonzalez 2011-04-06 08:43:54 PDT
Fixed at r83047