Bug 57706

Summary: [Qt] Radio buttons are showing wrong with mobile theme
Product: WebKit Reporter: Diego Gonzalez <diegohcg>
Component: WebKit QtAssignee: Diego Gonzalez <diegohcg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kenneth, ossy, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot showing the bug
none
Screenshot after patch
none
Patch none

Description Diego Gonzalez 2011-04-02 10:43:09 PDT
Radio buttons are shown wrong in case painting in a wide area 
like in: http://www.amw.com/missing_persons/search.cfm
Comment 1 Diego Gonzalez 2011-04-02 10:49:21 PDT
Created attachment 87977 [details]
Screenshot showing the bug
Comment 2 Diego Gonzalez 2011-04-02 10:50:02 PDT
Created attachment 87978 [details]
Screenshot after patch
Comment 3 Diego Gonzalez 2011-04-02 10:51:19 PDT
Created attachment 87979 [details]
Patch
Comment 4 Antonio Gomes 2011-04-03 19:34:11 PDT
Comment on attachment 87979 [details]
Patch

side =! size?
Comment 5 Eric Seidel (no email) 2011-04-03 22:56:44 PDT
Comment on attachment 87979 [details]
Patch

How do we test this?
Comment 6 Antonio Gomes 2011-04-03 23:00:16 PDT
(In reply to comment #5)
> (From update of attachment 87979 [details])
> How do we test this?

it is not tested, afaik.
Comment 7 Csaba Osztrogonác 2011-04-03 23:32:43 PDT
Comment on attachment 87979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87979&action=review

AFAIK we can test it, only if QT_MOBILE_THEME is true, but it isn't set by default.

Please fix the typo and the variable name before landing, otherwise LGTM, r=me.

> Source/WebCore/platform/qt/QtMobileWebStyle.cpp:92
> +    // get minor size to do not paint a wide elipse
> +    qreal side = qMin(size.width(), size.height());

// ... ellipse ...
radioButtonSize would be better name

> Source/WebCore/platform/qt/QtMobileWebStyle.cpp:94
> +    QRect rect = QRect(QPoint(1, 1), QSize(side - 2, side - 2));

ditto
Comment 8 WebKit Review Bot 2011-04-06 07:34:11 PDT
http://trac.webkit.org/changeset/83043 might have broken GTK Linux 64-bit Debug
Comment 9 Diego Gonzalez 2011-04-06 08:42:06 PDT
(In reply to comment #8)
> http://trac.webkit.org/changeset/83043 might have broken GTK Linux 64-bit Debug

I was not related with this patch
Comment 10 Diego Gonzalez 2011-04-06 08:42:53 PDT
Fixed at r83043