Bug 57704

Summary: Remove AbstractStep._run_script and move script names to ports.py
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Patrick R. Gansterer 2011-04-02 04:09:04 PDT
Remove AbstractStep._run_script and move script names to ports.py
Comment 1 Patrick R. Gansterer 2011-04-02 04:14:32 PDT
Created attachment 87974 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-02 04:48:23 PDT
Comment on attachment 87974 [details]
Patch

Sigh.  Well, this is a good thing to do, but there are two troubles I should point outin this patch.  1.  ports.py should die.  class methods aren't long-term scaleable.  We have a port.py over in layout_tests which we eventually want to merge it with/replace it with.

Second, run_and_throw_if_fail also is deprecated and should die. :)

That said, this is a great change to get rid of a fixme!

I'm glad to see you workign on webkitpy!
Comment 3 WebKit Commit Bot 2011-04-02 05:15:59 PDT
Comment on attachment 87974 [details]
Patch

Clearing flags on attachment: 87974

Committed r82771: <http://trac.webkit.org/changeset/82771>
Comment 4 WebKit Commit Bot 2011-04-02 05:16:04 PDT
All reviewed patches have been landed.  Closing bug.