Bug 57683

Summary:

WK2 Icon Database API needs to be fleshed out

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit wx

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	darin: review+, beidson: commit-queue-

Description Brady Eidson 2011-04-01 16:50:19 PDT

WK2 Icon Database API needs to be fleshed out

At least by bringing it to parity with the WK1 API in terms of notifications, etc.

Comment 1 Brady Eidson 2011-04-01 17:01:57 PDT

Created attachment 87945 [details]
Patch v1

Comment 2 Darin Adler 2011-04-01 17:35:32 PDT

Comment on attachment 87945 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=87945&action=review

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:208
> +{    

Stray whitespace crept in here.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:220
> +    RefPtr<WebURL> url = WebURL::create(pageURL);
> +    m_iconDatabaseClient.didChangeIconForPageURL(this, url.get());

I think this would read better without the local variable.

Comment 3 Brady Eidson 2011-04-04 09:03:04 PDT

http://trac.webkit.org/changeset/82839