Bug 57683

Summary: WK2 Icon Database API needs to be fleshed out
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit wxAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 darin: review+, beidson: commit-queue-

Brady Eidson
Reported 2011-04-01 16:50:19 PDT
WK2 Icon Database API needs to be fleshed out At least by bringing it to parity with the WK1 API in terms of notifications, etc.
Attachments
Patch v1 (20.91 KB, patch)
2011-04-01 17:01 PDT, Brady Eidson 		darin: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2011-04-01 17:01:57 PDT
Created attachment 87945 [details] Patch v1
Darin Adler
Comment 2 2011-04-01 17:35:32 PDT
Comment on attachment 87945 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=87945&action=review > Source/WebKit2/UIProcess/WebIconDatabase.cpp:208 > +{ Stray whitespace crept in here. > Source/WebKit2/UIProcess/WebIconDatabase.cpp:220 > + RefPtr<WebURL> url = WebURL::create(pageURL); > + m_iconDatabaseClient.didChangeIconForPageURL(this, url.get()); I think this would read better without the local variable.
Brady Eidson
Comment 3 2011-04-04 09:03:04 PDT
http://trac.webkit.org/changeset/82839
Note You need to log in before you can comment on or make changes to this bug.