Bug 57670

Summary:

Add adoptWK to WKRetainPtr.h

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	aroben: review+

Description Sam Weinig 2011-04-01 15:28:09 PDT

Add adoptWK to WKRetainPtr.h

Comment 1 Sam Weinig 2011-04-01 15:30:17 PDT

<rdar://problem/9224372>

Comment 2 Sam Weinig 2011-04-01 15:31:14 PDT

Created attachment 87929 [details]
Patch

Comment 3 Adam Roben (:aroben) 2011-04-01 15:32:44 PDT

Comment on attachment 87929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87929&action=review

> Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:207
> +template<typename T> static inline WKRetainPtr<T> adoptWK(const T o)

Is the const really helpful here? Won't all values of T be pointer types?

> Tools/TestWebKitAPI/PlatformUtilities.h:1
> -/*
> + /*

Whoopsie!

Comment 4 Sam Weinig 2011-04-01 15:35:43 PDT

Committed r82730: <http://trac.webkit.org/changeset/82730>

Comment 5 WebKit Review Bot 2011-04-01 15:46:02 PDT

http://trac.webkit.org/changeset/82730 might have broken Windows Release (Build) and Windows Debug (Build)