Bug 57641

Summary: Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Patch.
none
Patch. yurys: review+

Pavel Podivilov
Reported 2011-04-01 09:59:16 PDT
Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
Attachments
Patch. (8.55 KB, patch)
2011-04-01 10:00 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (17.41 KB, patch)
2011-04-04 09:02 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (15.72 KB, patch)
2011-04-06 02:39 PDT, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-04-01 10:00:18 PDT
Created attachment 87875 [details] Patch.
Yury Semikhatsky
Comment 2 2011-04-04 01:38:16 PDT
Comment on attachment 87875 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=87875&action=review > Source/WebCore/ChangeLog:10 > + * inline-javascript-imports.py: Added. This script should go into inspector/ dir or somewhere else but no in Sources/WebCore
Pavel Podivilov
Comment 3 2011-04-04 09:02:12 PDT
Created attachment 88066 [details] Patch.
Pavel Podivilov
Comment 4 2011-04-04 09:02:21 PDT
(In reply to comment #2) > (From update of attachment 87875 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87875&action=review > > > Source/WebCore/ChangeLog:10 > > + * inline-javascript-imports.py: Added. > > This script should go into inspector/ dir or somewhere else but no in Sources/WebCore Done.
Yury Semikhatsky
Comment 5 2011-04-06 01:38:47 PDT
Comment on attachment 88066 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=88066&action=review > Source/WebCore/inspector/combine-javascript-resources:1 > +#!/usr/bin/perl -w The script's file should have .pl extension like other standalone perl scripts that we use.
Pavel Podivilov
Comment 6 2011-04-06 02:39:36 PDT
Created attachment 88388 [details] Patch.
Pavel Podivilov
Comment 7 2011-04-06 06:20:06 PDT
Committed r83040: <http://trac.webkit.org/changeset/83040>
Note You need to log in before you can comment on or make changes to this bug.