Bug 57641

Summary: Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Patch.
none
Patch. yurys: review+

Description Pavel Podivilov 2011-04-01 09:59:16 PDT
Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
Comment 1 Pavel Podivilov 2011-04-01 10:00:18 PDT
Created attachment 87875 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-04-04 01:38:16 PDT
Comment on attachment 87875 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=87875&action=review

> Source/WebCore/ChangeLog:10
> +        * inline-javascript-imports.py: Added.

This script should go into inspector/ dir or somewhere else but no in Sources/WebCore
Comment 3 Pavel Podivilov 2011-04-04 09:02:12 PDT
Created attachment 88066 [details]
Patch.
Comment 4 Pavel Podivilov 2011-04-04 09:02:21 PDT
(In reply to comment #2)
> (From update of attachment 87875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87875&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        * inline-javascript-imports.py: Added.
> 
> This script should go into inspector/ dir or somewhere else but no in Sources/WebCore

Done.
Comment 5 Yury Semikhatsky 2011-04-06 01:38:47 PDT
Comment on attachment 88066 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=88066&action=review

> Source/WebCore/inspector/combine-javascript-resources:1
> +#!/usr/bin/perl -w

The script's file should have .pl extension like other standalone perl scripts that we use.
Comment 6 Pavel Podivilov 2011-04-06 02:39:36 PDT
Created attachment 88388 [details]
Patch.
Comment 7 Pavel Podivilov 2011-04-06 06:20:06 PDT
Committed r83040: <http://trac.webkit.org/changeset/83040>