Bug 57641 - Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
Summary: Web Inspector: inline script imports in ScriptFormatterWorker.js so it works ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 09:59 PDT by Pavel Podivilov
Modified: 2011-04-06 06:20 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (8.55 KB, patch)
2011-04-01 10:00 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (17.41 KB, patch)
2011-04-04 09:02 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (15.72 KB, patch)
2011-04-06 02:39 PDT, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-04-01 09:59:16 PDT 
Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
Comment 1 Pavel Podivilov 2011-04-01 10:00:18 PDT 
Created attachment 87875 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-04-04 01:38:16 PDT 
Comment on attachment 87875 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=87875&action=review

> Source/WebCore/ChangeLog:10
> +        * inline-javascript-imports.py: Added.

This script should go into inspector/ dir or somewhere else but no in Sources/WebCore
Comment 3 Pavel Podivilov 2011-04-04 09:02:12 PDT 
Created attachment 88066 [details]
Patch.
Comment 4 Pavel Podivilov 2011-04-04 09:02:21 PDT 
(In reply to comment #2)
> (From update of attachment 87875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87875&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        * inline-javascript-imports.py: Added.
> 
> This script should go into inspector/ dir or somewhere else but no in Sources/WebCore

Done.
Comment 5 Yury Semikhatsky 2011-04-06 01:38:47 PDT 
Comment on attachment 88066 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=88066&action=review

> Source/WebCore/inspector/combine-javascript-resources:1
> +#!/usr/bin/perl -w

The script's file should have .pl extension like other standalone perl scripts that we use.
Comment 6 Pavel Podivilov 2011-04-06 02:39:36 PDT 
Created attachment 88388 [details]
Patch.
Comment 7 Pavel Podivilov 2011-04-06 06:20:06 PDT 
Committed r83040: <http://trac.webkit.org/changeset/83040>